-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A0-544: Prepare alerts backup #329
Conversation
Please make sure the following happened
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, mostly notation comments, except the one about typing of BackupItem
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, feel free to resolve the last comment and either do this in a followup PR or just completely ignore it if it actually isn't helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left few small requests (address them) and suggestions/overall complaints about this part of AlephBFT (just consider them and resolve by yourself...).
The best I could do to keep `run` as the only async function...
This pr mainly refactors
runway/backup.rs
so that it accounts for different items in backup than only units.No saving backup in alerter yet.