A0-544: Alert backup preparation #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the following happened
|
woocash2
force-pushed
the
A0-544-initial-alert-backup
branch
from
ceb3878 to
994f765
Compare
woocash2
force-pushed
the
A0-544-initial-alert-backup
branch
2 times, most recently
from
4d9f19f to
149ab46
Compare
woocash2
force-pushed
the
A0-544-initial-alert-backup
branch
from
149ab46 to
7695a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
backupto be able to store not only units (UncheckedSignedUnit) but also objects of typeAlertandMultisigned. This is implemented by introducing an enumBackupItemwhich consists of variants which corresponds to the above types.There is a single receiver of
BackupIteminbackup::run_saving_mechanism.runwayandalertershould both have a sender which leads to this receiver inbackup.Currently no saving mechanism is implemented for
alerter, this pr only introduces the new structure ofBackupItemand adjustments tobackupandrunwaycaused by it.