Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wikiteq] Add Extension:JsonConfig, a dependency of Extension:Graph #442

Closed
wants to merge 1 commit into from

Conversation

labster
Copy link

@labster labster commented Sep 26, 2024

The dependency is needed to pass extension tests.

@labster labster requested a review from DanielWTQ September 26, 2024 08:16
Copy link

🐳 The image based on 787897af commit has been built with 1.39.8-20240926-442 tag as ghcr.io/canastawiki/canasta:wikiteq-787897af

@labster
Copy link
Author

labster commented Oct 7, 2024

More than likely we will not want to merge this due to the rather extensive security issues in Extension:Graph, though JsonConfig itself is fine.

@labster labster mentioned this pull request Dec 31, 2024
@labster
Copy link
Author

labster commented Dec 31, 2024

As Graph is going to be removed as of 1.43 in this branch and core Canasta, I'm going to close this. Not that there's anything per se wrong with JsonConfig, it's just unnecessary at this time.

@labster labster closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant