[Feature] support multiple volumes #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature-support-multiple-volumes
… you can have volumes with different settings. Also can expand into supporting S3 as well nicely (eventually)
Cameronsplaze
temporarily deployed
to
Minecraft-example.yaml
GitHub Actions
Inactive
Cameronsplaze
temporarily deployed
to
Palworld-example.yaml
GitHub Actions
Inactive
Cameronsplaze
temporarily deployed
to
Valheim-example.yaml
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several significant changes to the
ContainerManagerproject, primarily focusing on refactoring the EFS (Elastic File System) handling and updating configurations. The changes include restructuring the EFS setup, renaming classes, and updating configuration files to support multiple volumes. Here are the most important changes:Refactoring EFS Handling
Efsnested stack toVolumes, allowing support for multiple EFS file systems. (ContainerManager/leaf_stack/NestedStacks/Efs.py,ContainerManager/leaf_stack/NestedStacks/Volumes.py,ContainerManager/leaf_stack/NestedStacks/__init__.py) [1] [2] [3]EcsAsgto handle multiple EFS file systems and associated access points. (ContainerManager/leaf_stack/NestedStacks/EcsAsg.py) [1] [2] [3]Configuration Updates
ContainerManager/utils/config_loader.py)Volumesstructure. (Examples/Minecraft-example.yaml,Examples/Palworld-example.yaml,Examples/Valheim-example.yaml,Examples/README.md) [1] [2] [3] [4] [5]Code Cleanup
Efsnested stack class and related code. (ContainerManager/leaf_stack/NestedStacks/Efs.py)Minor Changes
EfstoVolumes. (ContainerManager/leaf_stack/NestedStacks/__init__.py)ContainerManager/leaf_stack/main.py) [1] [2] [3]RemovalPolicyimport inconfig_loader.py. (ContainerManager/utils/config_loader.py)