-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](mlu-ops): deprecate cnnl api and mlu-ops deprecated api #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duzekunKTH
force-pushed
the
deprecate_cnnl_binary
branch
from
January 10, 2024 09:00
8cec113
to
94d78be
Compare
PetrelYy
reviewed
Jan 12, 2024
docs/design_docs/masked_im2col_forward/masked_im2col_forward.md
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
Jan 12, 2024
duzekunKTH
force-pushed
the
deprecate_cnnl_binary
branch
from
January 12, 2024 02:43
b598d45
to
0d2db79
Compare
duzekunKTH
changed the title
Deprecate cnnl binary
[Feature](mlu-ops): deprecate cnnl api and mlu-ops deprecated api
Jan 12, 2024
PetrelYy
reviewed
Jan 12, 2024
PetrelYy
approved these changes
Jan 12, 2024
PetrelYy
approved these changes
Jan 12, 2024
DanieeelLiu
reviewed
Jan 12, 2024
kernels/indice_convolution_backward_data/indice_convolution_backward_data.h
Outdated
Show resolved
Hide resolved
kernels/mutual_information_forward/mutual_information_forward_utils.h
Outdated
Show resolved
Hide resolved
AquamarineSu
approved these changes
Jan 15, 2024
DanieeelLiu
approved these changes
Jan 15, 2024
duzekunKTH
force-pushed
the
deprecate_cnnl_binary
branch
from
January 15, 2024 09:10
d9823c6
to
090e22b
Compare
duzekunKTH
force-pushed
the
deprecate_cnnl_binary
branch
from
January 16, 2024 02:38
c7c6bca
to
bbdaeae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. 🚀🚀
1. Motivation
删除废弃的 cnnl 二进制算子,以及修改算子内调用逻辑。
2. Modification
Please briefly describe what modification is made in this pull request, and indicate where to make the modification.
Are new test cases added? If so, please post the corresponding generator-PR link here.
3. Test Report
If you want to know how to do operator testing, you can see GTest-User-Guide-zh.
3.1 Modification Details
3.2 Accuracy Test
在流水平台测试 370 & 590 通过。
3.3 Performance Test
不涉及性能
3.4 Summary Analysis
使用流水平台,功能测试每个算子随机测例100个测试通过。