Strip paste-bracketing control characters #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readline adds these by default, though that default is overridden in bash and python. It is not overriden in Octave and likely other REPLs as well.
blink1073
approved these changes
Jul 30, 2022
|
I thought this might also have fixed Calysto/octave_kernel#215, but it doesn't seem like it did? Should something else be done here, or should a similar change be applied to octave_kernel? |
|
Octave kernel is using run_command, so there shouldn't be anything extra to do there. I don't have Fedora set up to verify. |
|
Unfortunately not, using metakernel 0.29.2, then Calysto/octave_kernel#215 is not fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes downstream blink1073/oct2py#237 and blink1073/oct2py#248 as well as addressing the cause behind #228 .
The rationale is complicated somewhat by the fact that python disabled bracketed paste mode soon after #228, so that test doesn't fail anymore. I added a test that would fail without stripping the bracketing, by explicitly enabling it.
I think this is still the right place for this code (rather than downstream), since the readline default is to include the control characters, so I expect that stripping them will be common across multiple REPLs (including some
bashinvocations).