fix(intercom): safely check for app_id in optional param #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Because
intercomData
is optional in theboot
method then we need to use optional chaining to check forapp_id
otherwise it will error if that parameter is not passed onIntended/example use case:
app_id
is configured in theforRoot
method so when calling.boot()
without a paramter the lineconst app_id = intercomData.app_id ? intercomData.app_id : this.config.appId
will error sinceintercomData
is optional.Checklist:
npm run build
runs without errorng serve
spawns app, Intercom messenger is visible and interactive, and there are no errors in the consoleCloses issue: #