Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cam 461/wse vs reach for timeseries view #98

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Castronova
Copy link
Contributor

@Castronova Castronova commented Dec 5, 2024

Changes:

  1. Moved WSW vs Width from the node profile graph to the reach timeseries graph.
  2. Added a function to sort timeseries graph data along the x-axis before its rendered.
  3. Implemented X-sort prior to loading both reach and node charts.
  4. Added check to make sure that charts exist before we try to update their styles. This suppresses an error we get on initial loading of node profile charts.
  5. Changed the "Reach Timeseries" tab to "Reach Averaged"

@Castronova Castronova requested a review from devincowan December 5, 2024 14:16
…de profile charts, added check to make sure charts are not undefined when attempting to update them.
Copy link
Collaborator

@devincowan devincowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @Castronova! Nice!
Two things need to be fixed before we can merge:

  1. Please resolve conflicts with Develop (I checked, doesn't look like this should be too bad)
  2. There is a bug when you change the DQ settings after plotting the WSE/WIDTH
wse-vs-width.mov

@devincowan devincowan deployed to github-pages December 19, 2024 16:46 — with GitHub Actions Active
Copy link
Collaborator

@devincowan devincowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the code yet, but I see that you resolved the DataQuality bug that I noted on first review 👏

But I see that if I access this plot using a shared link, for example:
https://cuahsi.github.io/SWOT-Data-Viewer/#/plots/62222100021?variables=wse/width
then the plot is pretty funkified:
image

UPDATE: oh interesting, it looks like it is maybe because
https://cuahsi.github.io/SWOT-Data-Viewer/#/plots/62222100021?variables=wse/width
redirects to:
https://cuahsi.github.io/SWOT-Data-Viewer/#/plots/62222100021?variables=wse/time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants