Inclusion of new injection routes #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including three more specific injection routes requested as a part of ECTO manuscript edits
matentzn
requested changes
Dec 15, 2022
There was a problem hiding this comment.
You should be editing
https://github.com/CTDbase/exposure-ontology/blob/master/src/ontology/exo-edit.obo
you are editing the release file :) Sorry about that.
I do not do content review, but structurally it looks ok otherwise. I wonder whether a more unambiguous naming scheme would be better, like subcutaneous injection route, as subcutaneous sounds like a characteristic to me.
|
Whoops! I will shift those changes over to the obo file. @diatomsRcool any preference for the term labels? Happy to adjust if that more specific label is preferred. |
removing from the release file, will re-add to edit file
adding injection routes back into the edit file
matentzn
reviewed
Dec 15, 2022
updating diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including three more specific injection routes requested as a part of ECTO manuscript edits, completes #35