Replace raw pointers with unique_ptr and vector #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer using vector<T> when possible, but if we are unsure if it is possible, unique_ptr<T[]> allows us to more closely replace the raw pointer.
|
I have a commit coming that will change the raw pointers in aco.cpp and fix other bugs. The aco changes you are making are redundant. |
|
In most cases std::vector should be replaced with llvm::small_vector. This is standard in LLVM patches. |
|
Closing this. I'll open a new PR when I'm more actively working on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very-much-WIP branch for replacing raw pointer arrays with either
unique_ptr<T[]>orvector<T>.I can say that this currently compiles, but I haven't run anything with it. See #47 . There's still a lot of work to do here and I'm not prioritizing this, but I figured it would be good to PR this to allow collaboration / prevent duplicate work. Feel free to push more related changes to this branch.
I'm preferring using
vector<T>when possible, but if we are unsure if it is possible,unique_ptr<T[]>allows us to more closely replace the raw pointer.