Minor reformatting and changes to the HBVEC emulator #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include : - Reformatting the parameters class, hydro-meteorological processes, and soil parameters list (only cosmetic; no content change). - Adding explicitly the spatial interpolation to the HBVEC emulator configuration and the functionality necessary to the rvs.py configuration script. The default "INTERP_NEAREST_NEIGHBOR" interpolation was already executed implicitly by the model, but adding it in the model now gives users the flexibility to change the interpolation algorithm used if we wanted to. - Reordering the soil classes to follow the progression of soil layers from shallow to deep (only cosmetic; no content change). - Adding explicitly the soil parameters for the TOPSOIL class. This will give more flexibility to change parameter values for this layer independently.
for more information, see https://pre-commit.ci
…enPy into hbvec-improvements
huard
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
None foreseen. Existing tests should ensure that is the case.
Other information: