Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter HRUs with unrecognized hru_type attribute #344

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Filter HRUs with unrecognized hru_type attribute #344

merged 6 commits into from
Mar 11, 2024

Conversation

huard
Copy link
Collaborator

@huard huard commented Mar 6, 2024

Should fix #340

Adds a field validator on HRUs to ignore those with an hru_type that do not match expectations defined in the configuration.

Emits a UserWarning if some HRUs are ignored.

@huard huard requested a review from richardarsenault March 6, 2024 22:10
@coveralls
Copy link

coveralls commented Mar 6, 2024

Coverage Status

coverage: 81.652%. first build
when pulling ca2152d on fix-340
into 7bf874f on master.

@huard huard requested a review from lou-a March 7, 2024 03:06
Copy link
Collaborator

@richardarsenault richardarsenault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but the code looks good to me.

@huard huard merged commit 5f695fa into master Mar 11, 2024
22 checks passed
@huard huard deleted the fix-340 branch March 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distributed modelling using HBVEC fails on PAVICS notebooks
4 participants