-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and simplify testing data fetching #332
Conversation
…le` outside of initial fetching, yield dataset objects if possible, always fetch files from cache first
I've been really digging into this to see what's going on, and I can confidently say the following:
Let me know what you think about this so far. I see this PR as a bandage for the testing issues (much more stable) but once I can find the time to replace everything with pooch I can rewrite much more of the testing suite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks for looking into this. There is no reason for from_nc
to modify the dataset. Where do you see this happening ?
My bad, I was thinking of the I'll update the change log here, and hopefully we should have a (relatively) more stable testing experience going forwards. |
Changes
h5netcdf
as a core dependency, acting as a backup engine for reading netcdf files.model_copy(deep=True)
when dealing with Raven configs in the testing suite.autodoc-pydantic
for compatibility withpydantic
v2.0+pytest
fixtures that were causing problems in other tests.emulators
-basedpytest
fixtures; These are now loaded fromemulators.py
in thetests
folder.