Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 149 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 149 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented May 19, 2023

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @ishaan-upadhyay @TheDannyG @mirajismail @aajaleel @PDOracle @shinzahmed @aliasana

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
final-project-s23-citrus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 8:02pm

ishaan-upadhyay and others added 2 commits June 2, 2023 16:23
…ping

Fix: Vercel deployment broken due to Typescript hints not present
@vercel
Copy link

vercel bot commented Jun 2, 2023

@mirajismail is attempting to deploy a commit to the citrus-c01 Team on Vercel.

To accomplish this, @mirajismail needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@vercel
Copy link

vercel bot commented Jun 2, 2023

@aajaleel is attempting to deploy a commit to a Personal Account on Vercel that is not owned by them.

In order for the commit to be deployed, @aajaleel must be granted access to the connected Vercel project.

If you're the owner of the Personal Account, transfer the project to a Vercel Team and start collaborating, or learn more.

Co-authored-by: Ishaan Upadhyay <[email protected]>
mirajismail and others added 3 commits July 21, 2023 16:45
* finished org edit

* Trigger build

---------

Co-authored-by: Ishaan <[email protected]>
* Trigger build

* CIT-23: add Uninterest button

* CIT-23: switch to status api route

* CIT-23: add Uninterest button

* Trigger build

---------

Co-authored-by: Ishaan <[email protected]>
navn-r and others added 6 commits July 21, 2023 18:41
* commit

* add sprint 3 docs

Co-authored-by: aliasana <[email protected]>
Co-authored-by: mirajismail <[email protected]>
Co-authored-by: shinzahmed <[email protected]>
Co-authored-by: PDOracle <[email protected]>
Co-authored-by: Ishaan Upadhyay <[email protected]>

---------

Co-authored-by: mirajismail <[email protected]>
Co-authored-by: aliasana <[email protected]>
Co-authored-by: mirajismail <[email protected]>
Co-authored-by: shinzahmed <[email protected]>
Co-authored-by: PDOracle <[email protected]>
Co-authored-by: Ishaan Upadhyay <[email protected]>
* added contact page

* completed contact page

* [CIT-31] Fix unescaped chars

---------

Co-authored-by: Ishaan <[email protected]>
* [CIT-18] Overwrite from scratch

* CIT-18: fix user search api route, fix infinite scroll, fix search

* Trigger build

* CIT-18: clean up

---------

Co-authored-by: Ishaan <[email protected]>
Co-authored-by: Daniel <[email protected]>
mirajismail and others added 3 commits August 4, 2023 21:35
Co-authored-by: Ishaan Upadhyay <[email protected]>
Co-authored-by: PDOracle <[email protected]>
Co-authored-by: TheDannyG <[email protected]>
Great work everyone! 💪🚀
* [CIT-28] Make messaging API related changes

* [CIT-28] Get Ably demo working in prod

* [CIT-28] Begin adding code to persist messages

* [CIT-28] Group creation, message persistence

* [CIT-28] API rewrite into library functions

* [CIT-28] Intermediate commit

* [CIT-28] Cleanup, make groups secure

* [CIT-28] Cleanup

* [CIT-28] Cleanup, let users follow each other

* CIT-28: add link for chats

---------

Co-authored-by: Daniel <[email protected]>
aajaleel and others added 3 commits August 10, 2023 13:28
* edit client and server components for user profile

* user profile successfully updating

* bug fixes

* CIT-19: fix refresh, text boxes, api, profile display

* Trigger build

* CIT-19: bugfix

Co-authored-by: Ishaan Upadhyay <[email protected]>

* Trigger build

* add pricing

* [CIT-19] Visual improvements

* [CIT-19] Bugfix

---------

Co-authored-by: Daniel <[email protected]>
Co-authored-by: Ishaan <[email protected]>
Co-authored-by: Ishaan Upadhyay <[email protected]>
Co-authored-by: Ishaan Upadhyay <[email protected]>
* most functionality working

* payment done

* Trigger build

* CIT-26: add api change

* yes

* CIT-26: fix Miraj's unforgivable mistakes, add alerts to event creation, add link

* [CIT-26] Cleanup, fix success URL

[CIT-26] Fix login redirect

[CIT-26] Fix 1 last redirect

[CIT-26] Use normal redirect w/o NextResponse

[CIT-26] Fix redirect

* [CIT-26] Bugfix on all redirects

* [CIT-26] Bugfix on all redirects

---------

Co-authored-by: Ishaan <[email protected]>
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Ishaan Upadhyay <[email protected]>
* Bugfix: Malformed package-lock.json

* Bugfix: Malformed JSON files
* Bugfix: Missing change from rename

* add missing buttons

---------

Co-authored-by: Daniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants