Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed TaskToEvent class as it was acting as an unproductive Middle Man #63

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Removed TaskToEvent class as it was acting as an unproductive Middle Man #63

merged 5 commits into from
Nov 25, 2021

Conversation

ckatsube
Copy link
Contributor

Part of #62

@ckatsube
Copy link
Contributor Author

Instead of just dropping the middle man I also decided to include an interface between the controllers and use case. The current interface is a bit unstable and is probably going to be subject to changes or removal later, but I didn't want to introduce another DIP violation for no reason.

@ckatsube ckatsube merged commit 55974d9 into main Nov 25, 2021
@ckatsube ckatsube deleted the remove-task-to-event-middle-man branch November 25, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunruL JunruL JunruL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckatsube @JunruL