Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull changes from main into branch #22

Closed
wants to merge 7 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated cran-comments and NEWS with notes about patch changes
  • Loading branch information
stephaniereinders committed Sep 4, 2024
commit fc5d3166bd5f0efcc72021b96eaec0323d1fa508
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# handwriterApp 1.0.1

* Changed the title from "Shiny App for Handwriting Analysis in R" to "A 'shiny' Application for Handwriting Analysis"

* Placed package names in single undirected quotes, and changed directed quotation marks to undirected quotes in the description text.

* Added "\value{No return value, called to launch 'shiny' app}" to the .Rd file for for the exported method handwriterApp().

# handwriterApp 1.0.0

* Initial CRAN submission.
4 changes: 2 additions & 2 deletions R/app.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
@@ -18,7 +18,7 @@

#' Handwriter Application
#'
#' Lauch a Shiny App for 'handwriter'.
#' Lauch a 'shiny' application for 'handwriter'.
#'
#' @param ... Other arguments passed on to 'onStart', 'options',
#' 'uiPattern', or 'enableBookmarking' of 'shiny::shinyApp'
2 changes: 1 addition & 1 deletion R/case_known.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/case_maindir.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/case_qd.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/case_report.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/current_image.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/data.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/demo_preview.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/inner.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/server_utils.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
2 changes: 1 addition & 1 deletion R/ui_utils.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The handwriterApp R package performs writership analysis of handwritten
# The 'handwriterApp' R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
18 changes: 0 additions & 18 deletions R/utils-pipe.R
Original file line number Diff line number Diff line change
@@ -1,21 +1,3 @@
# The handwriterApp R package performs writership analysis of handwritten
# documents. Copyright (C) 2024 Iowa State University of Science and Technology
# on behalf of its Center for Statistics and Applications in Forensic Evidence
#
# This program is free software: you can redistribute it and/or modify it under
# the terms of the GNU General Public License as published by the Free Software
# Foundation, either version 3 of the License, or (at your option) any later
# version.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
# details.
#
# You should have received a copy of the GNU General Public License along with
# this program. If not, see <https://www.gnu.org/licenses/>.


#' Pipe operator
#'
#' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details.
18 changes: 11 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
## R CMD check results
## Resubmission
This is a resubmission. In this version I have:

0 errors | 0 warnings | 1 note
* Changed the title from "Shiny App for Handwriting Analysis in R" to "A 'shiny' Application for Handwriting Analysis"

* Placed package names in single undirected quotes, and changed directed quotation marks to undirected quotes in the description text.

* Added "\value{No return value, called to launch 'shiny' app}" to the .Rd file for for the exported method handwriterApp().

checking CRAN incoming feasibility ... [3s/12s] NOTE
Maintainer: ‘Stephanie Reinders <srein@iastate.edu>’

New submission
* Verified that functions do not write by default or in examples/vignettes/tests in the user's home filespace (including the package directory and getwd()).

* This is a new release
## R CMD check results

0 errors | 0 warnings | 1 note
2 changes: 1 addition & 1 deletion man/handwriterApp.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.