Updated cran-comments and NEWS with notes about patch changes

CSAFE-ISU · Sep 4, 2024 · fc5d316 · fc5d316
1 parent eaa918a
commit fc5d316
Show file tree

Hide file tree

Showing 15 changed files with 30 additions and 38 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,11 @@
 # handwriterApp 1.0.1
 
+* Changed the title from "Shiny App for Handwriting Analysis in R" to "A 'shiny' Application for Handwriting Analysis"
+
+* Placed package names in single undirected quotes, and changed directed quotation marks to undirected quotes in the description text.
+
+* Added "\value{No return value, called to launch 'shiny' app}" to the .Rd file for for the exported method handwriterApp().
+
 # handwriterApp 1.0.0
 
 * Initial CRAN submission.
diff --git a/R/app.R b/R/app.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #
@@ -18,7 +18,7 @@
 
 #' Handwriter Application
 #' 
-#' Lauch a Shiny App for 'handwriter'.
+#' Lauch a 'shiny' application for 'handwriter'.
 #'
 #' @param ... Other arguments passed on to 'onStart', 'options',
 #'   'uiPattern', or 'enableBookmarking' of 'shiny::shinyApp'

diff --git a/R/case_known.R b/R/case_known.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/case_maindir.R b/R/case_maindir.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/case_qd.R b/R/case_qd.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/case_report.R b/R/case_report.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/current_image.R b/R/current_image.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/data.R b/R/data.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/demo_preview.R b/R/demo_preview.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/inner.R b/R/inner.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/server_utils.R b/R/server_utils.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/ui_utils.R b/R/ui_utils.R
@@ -1,4 +1,4 @@
-# The handwriterApp R package performs writership analysis of handwritten
+# The 'handwriterApp' R package performs writership analysis of handwritten
 # documents. Copyright (C) 2024 Iowa State University of Science and Technology
 # on behalf of its Center for Statistics and Applications in Forensic Evidence
 #

diff --git a/R/utils-pipe.R b/R/utils-pipe.R
@@ -1,21 +1,3 @@
-# The handwriterApp R package performs writership analysis of handwritten
-# documents. Copyright (C) 2024 Iowa State University of Science and Technology
-# on behalf of its Center for Statistics and Applications in Forensic Evidence
-#
-# This program is free software: you can redistribute it and/or modify it under
-# the terms of the GNU General Public License as published by the Free Software
-# Foundation, either version 3 of the License, or (at your option) any later
-# version.
-#
-# This program is distributed in the hope that it will be useful, but WITHOUT
-# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
-# FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
-# details.
-#
-# You should have received a copy of the GNU General Public License along with
-# this program.  If not, see <https://www.gnu.org/licenses/>.
-
-
 #' Pipe operator
 #'
 #' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details.

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,10 +1,14 @@
-## R CMD check results
+## Resubmission
+This is a resubmission. In this version I have:
 
-0 errors | 0 warnings | 1 note
+* Changed the title from "Shiny App for Handwriting Analysis in R" to "A 'shiny' Application for Handwriting Analysis"
+
+* Placed package names in single undirected quotes, and changed directed quotation marks to undirected quotes in the description text.
+
+* Added "\value{No return value, called to launch 'shiny' app}" to the .Rd file for for the exported method handwriterApp().
 
-checking CRAN incoming feasibility ... [3s/12s] NOTE
-  Maintainer: ‘Stephanie Reinders <[email protected]>’
-
-  New submission
+* Verified that functions do not write by default or in examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). 
 
-* This is a new release
+## R CMD check results
+
+0 errors | 0 warnings | 1 note
diff --git a/man/handwriterApp.Rd b/man/handwriterApp.Rd