Fixed navbar mobile problems #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Introduces Bug #47 |
Closed
|
Also made font sizes change based on window size, making for a better mobile experience, and plugged in the homepage buttons |
ScratchnSniff0
approved these changes
Oct 17, 2020
caydenreynolds
added a commit
that referenced
this pull request
Dec 3, 2020
* basic react app you **probably** don't want to pull this yet. I'm just using guthub to get these files from my desktop to my laptop * Created Basic Homepage for MS1 * Committing to show routing * Good enough mock up of simulation builder * Added RouteBuilder, to handle all of our routing * Added docstrings * Began work on Playerpage.js (#36) Began work on Playerpage.js. The page still needs remodeled. Co-Authored-By: Alex Louderback <[email protected]> Co-authored-by: Alex Louderback <[email protected]> * Added importable stylesheet file * Mockup account (#41) * Publishing mockup-login/signup branch I mostly have the page mockup done and am publishing the branch for it. * Publishing mockup-account I am publishing the branch for the mockup of account. Page is done but needs remodeling. I didn't think I would be done this fast after the other branch, so merge this one after Login/Signup branch? I don't know if there would be any git conflicts that would delete something from the other branch. Anyway, solves #39 * Plugin playerpage (#42) * Added simple schemas * Playerpage mostly-sorta works now * Removed some extra stuff * Added response to playerpage * Fixed imports * Adding schema submodule (#43) * Almost there * Forgot to remove the old stuff * Changed the color, code cleanup (#48) * Changed the color, code cleanup I changed the color, remodeled some buttons, and cleaned up some unnecessary code. Co-Authored-By: caydenreynolds <[email protected]> * Delete theme.html We don't need this. * Remodeled some more, add About Page I've added the about page mockup, and edited alot of other pages to get rid of code that seemed to not be doing anything. I did not mess with factorypage or playerpage as I didn't want to step on any toes. Co-authored-by: caydenreynolds <[email protected]> * Fixed navbar mobile problems (#46) * Simul;ation Factory Start Still need to finish splitting add event, prompt, and response * Split response, prompt, event methods Cards still aren't built * Broken implementation of dialog box with lookup table just moving between computers & using github to push changes. not functional. probably shouldve been working in my own branch anyways. * Fixing up playerpage a bit. Commented out some unused lines of code. Fixed some compiler warnings. Edited the create simulation page to have textfields for the event and response buttons. The six extra textfields for response is only temporary, we plan to add a way to dynamically add textfields. * Added the dynamic buttons. Added the dynamic buttons. * Built table component Ended up building my own spreadsheet from scratch because nothing was giving me what I wanted. Probably overengineered it, but its now more customizable than anything else out there. still need to add ability for users to add/delete rows * Made the Add player, resource button dialogs I've fixed an import and added player and resource adding dialogs, all we have to do is make it so they actually work. There is also a wierd error where the compiler complains about /factorypage already existing whenever the moar_watches thing updates the page. * Playerpage minimally functional (#54) * Committing to change branch * Playerpage works, kinda * Env variables Co-authored-by: Brandon Miller <[email protected]> * Commiting to change branch * Factory page creates simulations and frames * Front end lookup table (#68) * Begun work on importing excel files I've begun cleaning up a bit by removing the table, and adding a dropbox instead. The drag and drop doesn't work yet, BUT if you click on it you can select your file. The contents of the file will then be outputted to the console log. In the future we can split up the data and send it to the proper place. * Code Cleanup and Some Documentation Cleaned up some imports, added some newlines to the end of files, added some comments to the files to document functionality. * Edited Backend-Drop-Sim_schem Getting ready to connect to backend. * End-to-end functionality, with help from Brandon * About Page Did more with the about page. Co-authored-by: Brandon Miller <[email protected]> Co-authored-by: alouderback <[email protected]> Co-authored-by: Brandon Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the navbar to be spaced correctly on desktop, and to be openable on mobile. Closes #45
Navbar and Topbar have been combined into one file