generated from CS3219-AY2324S1/course-assessment-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create release 1.3.0 #260
Merged
Merged
Create release 1.3.0 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #240 - Now users can swap to another random question. - Requires the other user to acknowledge. --------- Co-authored-by: Ong Jun Xiong <[email protected]>
Often, the frontend makes so many duplicate socket connections to the backend. Also, the video room display name is currently always set to the user id, which is not human-readable... And we should not allow any unauthorized user to join a room in collaboration service. This PR fixes these problems.
… function to reuse difficulty color logic across components (#250) This pull request updates the matchingController and questionAdapter files to ensure the room has the question and the default code. It also adds a new getDifficultyColor function to the difficulty-selector file. This function allows for the reuse of difficulty color logic across components.
yhtMinceraft1010X
temporarily deployed
to
production
November 15, 2023 03:22 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.