generated from CS3219-AY2324S1/course-assessment-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create release 1.0.0 #232
Merged
Merged
Create release 1.0.0 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gateway does not detect the user id param in the path, causing verification to fail and redirect to the frontend address. Let's add a new header to store the current user id, which should be the same as that of the param uid.
Docker Compose has largely been sidelined as a tool for developing the app since a script that does not use Docker for starting up all the services at once has been created. Let's repurpose Docker Compose to be a prod checker. The same images that are built for Google Kubernetes Engine will also be built for Docker Compose so that we can have a good idea of whether the app will still work in production after it has already been proven to work in development.
TODO: - Only admins can contribute, edit and delete questions - Normal users should be able to only see the list of questions and should not be able to access edit question page - User profile management stuff??? (Not too familiar, pls help)
Changes: - Add environment variables at places where `localhost` is hard-coded. This is to support using Docker/Kubernetes addressing in the production environment. - Remove unused and commented out code - Refine Markdown documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official launch of CodeParty.