Fix Docker frontend build #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todos: make question service work with collaboration service and matching service can merge this before it gets too large - i've split the tickets alr fixes #71 --------- Co-authored-by: YIHSUEN\Yi Hsuen <[email protected]> Co-authored-by: Charisma Kausar <[email protected]>
Let's rename the env variables associated with the prisma relational database to avoid ambiguity and confusion with MongoDB.
- Operational Transformations in Collaboration Service - Add utils/shared-ot.ts - next.config.js: Enable experimental feature - external dir - Some scary warning appears here - Fix frontend - remove debouncer - Add cursor support, defaults to 0 Current design: Client --> Server: OT + Cursor Server --> Client: Full text + Version number + Cursor Version number incremented by Server, client should not increment because version number refers to previous version that is edited upon. Client waits for: - Acknowledgement from server of prev request - Sync version (and text) from server before they can send the next update request This ensures no conflicting versions and mix-ups.
Let's add a production deployment workflow.
Fix #76 , fix #95 - On save text (save API) and disconnect of all users, will save Attempt - if question_id not set, it will be empty string - (Collab service) socket emit `api/collaboration-service/question/set` to set question_id - (User service) - `api/user-service/:uid/attempts/` to get attempts of user - `api/user-service/attempt/` to create an attempt - uid string - question_id string - answer string - solved? boolean defaults to false Frontend can call user service to save attempt for attempts done alone (without collaboration rooms)
The prod workflow is currently failing at the first step due to permission issues on the workflow file side.
The 400 error when POSTing to the database when the user is already inside can surprise developers during debugging because everytime a user logs in, the POST is made regardless of whether the user is inside the database or not. Let's change the status code to 200 to avoid showing it as an error while still differentiating it from the status code 201 when the user details are added for the first time.
Use Twilio video call API. Also change Dockerfile to add utils as a dependency To use: - Add new variables to .env file ``` TWILIO_ACCOUNT_SID= TWILIO_API_KEY= TWILIO_API_SECRET= ``` - Run the collab service and frontend - Visit http://localhost:3000/room/1?userId=user2 or choose a different room/user id - Visit http://localhost:3000/room/1?userId=user2&disableVideo=true if you don't want to use video (save cost)
yhtMinceraft1010X
had a problem deploying
to
production
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.