Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release 0.1.1 #101

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Create release 0.1.1 #101

merged 11 commits into from
Oct 16, 2023

Conversation

yhtMinceraft1010X
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X commented Oct 16, 2023

Fix missing permissions for running production workflow

ong6 and others added 11 commits October 11, 2023 16:51
todos: 
make question service work with collaboration service and matching
service

can merge this before it gets too large - i've split the tickets alr

fixes #71

---------

Co-authored-by: YIHSUEN\Yi Hsuen <[email protected]>
Co-authored-by: Charisma Kausar <[email protected]>
Let's rename the env variables associated with the prisma relational 
database to avoid ambiguity and confusion with MongoDB.
- Operational Transformations in Collaboration Service
- Add utils/shared-ot.ts
  - next.config.js: Enable experimental feature - external dir
  - Some scary warning appears here
- Fix frontend
  - remove debouncer
- Add cursor support, defaults to 0

Current design:

Client --> Server: OT + Cursor
Server --> Client: Full text + Version number + Cursor

Version number incremented by Server, client should not increment
because version number refers to previous version that is edited upon.

Client waits for: 
- Acknowledgement from server of prev request
- Sync version (and text) from server
before they can send the next update request

This ensures no conflicting versions and mix-ups.
Let's add a production deployment workflow.
Fix #76 , fix #95

- On save text (save API) and disconnect of all users, will save Attempt
  - if question_id not set, it will be empty string 
- (Collab service) socket emit `api/collaboration-service/question/set`
to set question_id
- (User service) 
  - `api/user-service/:uid/attempts/` to get attempts of user
  - `api/user-service/attempt/` to create an attempt
    - uid string
    - question_id string
    - answer string
    - solved? boolean defaults to false

Frontend can call user service to save attempt for attempts done alone
(without collaboration rooms)
The prod workflow is currently failing at the first step due to
permission issues on the workflow file side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants