generated from CS3219-AY2324S1/course-assessment-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Communication Service for users in room #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josephaedan
force-pushed
the
feat/communication-service
branch
from
November 10, 2023 13:27
be2d00d
to
a565215
Compare
Josephaedan
force-pushed
the
feat/communication-service
branch
from
November 10, 2023 17:27
92e9d31
to
940ac09
Compare
raynerljm
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one thing, the FE has a missing dependency for @codemirror/collab. also can u help to update the root README.md
with details about setting up the communication-service env vars + the fact that the comm service is on localhost:8006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to existing process flow:
Changes to API Gateway
/communication
to Communcation ServiceChanges to docker-compose.yaml
Changes to Matching Service
Communication Service
Frontend
Changes to Existing Implementation
AlwaysScrollToBottom
helper function for utilsNew Implementation Decisions
useChatStore
Zustand Store for storing and accessing messages in the chatroom. This is used because Zustand allows for components to access different parts of the state and also subscribe to specific states for things like detecting notifications and deleting the store upon changing rooms (and also because we need to justify having Zustand).