Possible fix for wrong secondary masses of photons and neutrinos #484
Conversation
… lines for non-nuclei
…nuclei as suggested by Lukas and Julien
CHANGELOG.md
Outdated
|
|
||
| ### New features: | ||
|
|
||
| ### Interface changes: | ||
| * Added new backwards-compatible function particleMass that returns particle mass also for non-nuclei |
There was a problem hiding this comment.
Add this to new features, as the old interface stays the same.
There is no change in behaviour for the old functions, which are available for the user.
| @param id id of the particle following the PDG numbering scheme | ||
| @returns The mass of a the particle | ||
| */ | ||
| double particleMass(int id); |
There was a problem hiding this comment.
add whiteline between the function definition and the comment for the next function.
src/ParticleMass.cpp
Outdated
| if (isNucleus(id)) | ||
| return nuclearMass(id); | ||
| if (abs(id) == 11) | ||
| m = mass_electron; |
There was a problem hiding this comment.
why is it here not a direct return statement. This would reduce the code amount.
|
Looks good to me. Let's wait for more comments otherwise I will merge in the next days. |
|
Thank you very much for your feedback! |
…ing new test for the particleMass() function
Dear all,
with this PR we try to fix #483. @lukasmerten, @JulienDoerner and me discussed it and introduced a new function particleMass(int id) in ParticleMass.cpp to fix the bug by calling it in setId(int newId) in ParticleState.cpp. It gives all particles other than nuclei or electrons/positrons a zero rest-mass and could possibly be extended for other particles when needed.