custom photon fields #218
Closed
custom photon fields #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update docstrings
- remove internal background photon sampling - remove unused input- and output parameters - rename some variables to gain readability - replace GOTO statements by safe control structures - implement unified indentation scheme - simplify functions where appropriate
- add geometry & time dependence of photon field
- implement interpolation routine for ScalarGrid4d
- remove option for non-redshift dependence - implement histogram version of SOPHIA
- implement geometry and time dependence
- remove option for non-redshift dependence - implement geometry and time-dependence - implement histogram version of SOPHIA
- implement a generalized version of SOPHIA's background photon sampling routine
- add ability to tag secondaries in module
add tag option
improve readability
…creasing s_max to very high value. Interpolation precision may have been compromised in log-space but probably isn't too severe
|
As the debate has moved on, this particular PR will be closed. Any discussion is documented #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
this pull request aims to introduce the following changes to CRPropa:
fully customizable photon fields:
a) in addition to previous photon fields (CMB, IRBs) there are 8 open slots PF1...PF8 for custom fields
b) each photon field satisfies a certain format encoding energy- and redshift dependence
c) the tabulated files needed by the interaction modules can be generated by a central external file
d) the field slots PF1...PF8 may be modified at will after CRPropa has been installed
e) the photon field file itself and the tabulated files are stored in the ~/share/crpropa directory
f) field photons can now be sampled by a class provided in PhotonBackground.cpp
g) SOPHIA had to undergo significant changes in this process
space- and time dependence
a) interaction modules support space- and time dependence of photon fields
b) for this the ScalarGrid4d type has been added which generalizes ScalarGrid to 4 dimensions
c) interaction modules take a ScalarGrid4d encoding space- and time dependence
d) ScalarGrid4d comes with its most-needed tools e.g. interpolation, loadGridFromTxt, etc.
discretized version of SOPHIA
a) a SOPHIA event generator based on histogram data may be used in the PhotoPionProduction
b) this may be controlled via a new flag in PhotoPionProduction: useTabulatedData = true/false
c) see issue discretize SOPHIA #213 for details of this implementation
d) NOTE: this tightly relates to the modified version of SOPHIA that came with 1g)
Looking forward to receiving feedback from you!
All the best,
Mario