bug: title fix for storybook #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhdeep12
changed the title
| @@ -5,6 +5,9 @@ | |||
| <meta property="og:description" content="NeoPOP Design System by CRED" /> | |||
| <meta property="og:title" content="CRED Design System" /> | |||
| <title>NeoPOP Design System</title> | |||
| <script> | |||
There was a problem hiding this comment.
TBH this seems like a hack let's wait for storybook to fix this can we? It is already merged and made it to the pre release (https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.10) and then we can update the dependency instead of doing this?
There was a problem hiding this comment.
Yes @harish-sethuraman. Since storybook is fixing this issue I should close this PR.
Thanks for the update.
harish-sethuraman
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
From
To
#21