Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unicode pi symbols in rotation extension #743

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jan 8, 2025

No description provided.

@ss2165 ss2165 requested a review from a team as a code owner January 8, 2025 17:24
@ss2165 ss2165 requested a review from cqc-alec January 8, 2025 17:24
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (0c6101b) to head (7355970).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   82.62%   82.67%   +0.05%     
==========================================
  Files          62       62              
  Lines        7234     7234              
  Branches     6978     6978              
==========================================
+ Hits         5977     5981       +4     
+ Misses        883      880       -3     
+ Partials      374      373       -1     
Flag Coverage Δ
python 82.42% <ø> (ø)
rust 82.68% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit b3ed351 Jan 9, 2025
17 checks passed
@ss2165 ss2165 deleted the ss/no-pi branch January 9, 2025 09:05
This was referenced Jan 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
## 🤖 New release
* `tket2`: 0.7.0 -> 0.7.1 (✓ API compatible changes)
* `tket2-hseries`: 0.7.1 -> 0.8.0 (⚠️ API breaking changes)

### ⚠️ `tket2-hseries` breaking changes

```
--- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value ---

Description:
The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_no_repr_variant_discriminant_changed.ron

Failed in:
  variant QSystemOp::Rz 2 -> 3 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:88
  variant QSystemOp::PhasedX 3 -> 4 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:89
  variant QSystemOp::ZZMax 4 -> 5 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:90
  variant QSystemOp::ZZPhase 5 -> 6 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:91
  variant QSystemOp::TryQAlloc 6 -> 7 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:92
  variant QSystemOp::QFree 7 -> 8 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:93
  variant QSystemOp::Reset 8 -> 9 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:94
  variant QSystemOp::MeasureReset 9 -> 10 in /tmp/.tmp2ye8Ro/tket2/tket2-hseries/src/extension/qsystem.rs:95
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.7.1](tket2-v0.7.0...tket2-v0.7.1)
- 2025-01-10

### Bug Fixes

- remove unicode pi symbols in rotation extension (#743)
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.8.0](tket2-hseries-v0.7.1...tket2-hseries-v0.8.0)
- 2025-01-10

### New Features

- *(tket2-hseries)* [**breaking**] Redefine `QSystemOp::LazyMeasure` and
introduce `QSystemOp::LazyMeasureReset` (#741)
- *(tket2-hseries)* Lazify more flavours of measure ops (#742)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants