Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop viz_hugr test utils #734

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

See CQCL/hugr#1789

webbrowser now requires rust 1.81 on linux targets, so we better just drop it.

Also removes a couple unused dependencies detected with cargo-machete

@aborgna-q aborgna-q requested a review from a team as a code owner December 18, 2024 16:49
@aborgna-q aborgna-q requested a review from ss2165 December 18, 2024 16:49
@aborgna-q aborgna-q force-pushed the ab/drop-webbrowser-dev-dep branch from e9aaff3 to c8e555d Compare December 18, 2024 16:49
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@aborgna-q aborgna-q enabled auto-merge December 18, 2024 16:52
@aborgna-q aborgna-q added this pull request to the merge queue Dec 18, 2024
@aborgna-q aborgna-q removed this pull request from the merge queue due to a manual request Dec 18, 2024
@aborgna-q aborgna-q force-pushed the ab/drop-webbrowser-dev-dep branch from c8e555d to 3099eeb Compare December 18, 2024 16:56
@aborgna-q aborgna-q enabled auto-merge December 18, 2024 16:56
@aborgna-q aborgna-q added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 5cf93af Dec 18, 2024
15 checks passed
@aborgna-q aborgna-q deleted the ab/drop-webbrowser-dev-dep branch December 18, 2024 17:03
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (51a1424) to head (3099eeb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   82.67%   82.62%   -0.06%     
==========================================
  Files          62       62              
  Lines        7234     7234              
  Branches     6978     6978              
==========================================
- Hits         5981     5977       -4     
- Misses        880      883       +3     
- Partials      373      374       +1     
Flag Coverage Δ
python 82.42% <ø> (ø)
rust 82.63% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants