chore: use MonomorphizationPass #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
approved these changes
Dec 18, 2024
tket2-hseries/src/lib.rs
Outdated
| @@ -61,21 +61,16 @@ pub enum QSystemPassError { | |||
| LowerTk2Error(LowerTk2Error), | |||
| /// An error from the component [ConstantFoldPass] pass. | |||
| ConstantFoldError(ConstFoldError), | |||
| /// An error from the component [MoomorphizePass] pass. | |||
There was a problem hiding this comment.
Suggested change
| /// An error from the component [MoomorphizePass] pass. | |
| /// An error from the component [MonomorphizePass] pass. |
tket2-hseries/src/lib.rs
Outdated
| @@ -61,21 +61,16 @@ pub enum QSystemPassError { | |||
| LowerTk2Error(LowerTk2Error), | |||
| /// An error from the component [ConstantFoldPass] pass. | |||
| ConstantFoldError(ConstFoldError), | |||
| /// An error from the component [MoomorphizePass] pass. | |||
| MonomorphizeError(hugr::algorithms::MonomorphizeError), | |||
There was a problem hiding this comment.
It's inconsistent with the above to qualify this here. It's Ok if you prefer it.
doug-q
requested changes
Dec 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
==========================================
- Coverage 82.68% 82.67% -0.01%
==========================================
Files 62 62
Lines 7231 7234 +3
Branches 6975 6978 +3
==========================================
+ Hits 5979 5981 +2
Misses 880 880
- Partials 372 373 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
doug-q
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.