Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to hugr 0.13.2, fix deprecation warnings #669

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Oct 22, 2024

We can now drop the dependency on hugr-cli for tket2{,-py}.

Hugr roots now have (disconnected) ports, so I had to fix the low-level rewrite_dfg to ensure we keep the root valid.

@aborgna-q aborgna-q requested a review from a team as a code owner October 22, 2024 16:13
@aborgna-q aborgna-q requested a review from doug-q October 22, 2024 16:13
@aborgna-q aborgna-q changed the title chore: Update to hugr 0.12.2 chore: Update to hugr 0.13.2, fix deprecation warnings Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (6a31663) to head (894f05d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket2/src/serialize/guppy.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   82.14%   82.17%   +0.02%     
==========================================
  Files          50       50              
  Lines        6777     6781       +4     
  Branches     6777     6781       +4     
==========================================
+ Hits         5567     5572       +5     
+ Misses        846      845       -1     
  Partials      364      364              
Flag Coverage Δ
rust 82.17% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hugr-cli = "0.13.1"
hugr = "0.13.2"
hugr-core = "0.13.2"
hugr-cli = "0.13.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be gone right?

Suggested change
hugr-cli = "0.13.2"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a dependency of tket2-hseries, we only dropped it from tket2 and tket2-py

@aborgna-q aborgna-q added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 2226fed Oct 23, 2024
17 of 18 checks passed
@aborgna-q aborgna-q deleted the ab/update-hugr branch October 23, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants