ci: Ensure we're using the right py version when testing on CI #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
added
the
run-ci-checks
aborgna-q
force-pushed
the
ab/unsupported-python-313
branch
from
e90b973 to
feb2f91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 50 50
Lines 6766 6766
Branches 6766 6766
=======================================
Hits 5548 5548
Misses 854 854
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
force-pushed
the
ab/unsupported-python-313
branch
from
feb2f91 to
1df24c6
Compare
cqc-alec
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#653 enabled support for python 3.13, but CI should have failed since the
pytketdependency does not publish wheels for 3.13.This PR ensures uv doesn't fallback to a lower version when it encounters unsupported dependencies.