chore: Move pyproject.toml to tket2-py
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
added
the
run-ci-checks
aborgna-q
force-pushed
the
ab/tket2-py-pyproject
branch
from
6c177df to
c0ce94e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 45 45
Lines 6206 6206
Branches 6206 6206
=======================================
Hits 5153 5153
Misses 771 771
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
croyzor
approved these changes
Aug 16, 2024
cqc-alec
approved these changes
Aug 22, 2024
Co-authored-by: Alec Edgington <[email protected]>
This was referenced Sep 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Fixes #586, which was broken when we moved `pyproject.toml` in #546. Running `maturin build` from the root dir tries to build the workspace project, creating an invalid wheel name. This PR updates the ci job and the `just build` command to run maturin from inside `/hugr-py/`. Maturin is still configured as a build tool in the workspace so that `maturin develop` works everywhere. In that case we don't care about the project name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with
release-pleasenot detecting changes topyprojectas relevant totket2-py.If things are correct, development commands (maturin / poetry / ...) should run as before.
Closes #541