Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace build.rs with lint config in Cargo.toml #509

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Jul 25, 2024

Rust 1.80 just dropped, adding a lint option that allows us to avoid the build.rs definition added in #386.
(The nightly lint got updated before hitting beta, so there shouldn't be compatibility problems there).

@aborgna-q aborgna-q requested a review from a team as a code owner July 25, 2024 12:54
@aborgna-q aborgna-q requested a review from doug-q July 25, 2024 12:54
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (fe7d40e) to head (b4992a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          64       64           
  Lines        6647     6647           
  Branches     6126     6126           
=======================================
  Hits         5550     5550           
  Misses        817      817           
  Partials      280      280           
Flag Coverage Δ
python 96.73% <ø> (ø)
rust 82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

This will with older rustcs, we don't care because we only require the latest in CI?

@aborgna-q
Copy link
Collaborator Author

The lint never dropped in stable, so things will still pass there.
The CI error only appeared in the nightly checks, before the lint config was added.

@aborgna-q aborgna-q added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 7b14f18 Jul 25, 2024
17 checks passed
@aborgna-q aborgna-q deleted the ab/drop-build-rs branch July 25, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants