Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-rs): Update to hugr 0.9.0 #497

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore(deps-rs): Update to hugr 0.9.0 #497

merged 1 commit into from
Jul 19, 2024

Conversation

aborgna-q
Copy link
Collaborator

No description provided.

@aborgna-q aborgna-q requested a review from doug-q July 19, 2024 10:35
@aborgna-q aborgna-q requested a review from a team as a code owner July 19, 2024 10:35
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (034ab9c) to head (716e9ce).

Files Patch % Lines
tket2/src/circuit.rs 50.00% 1 Missing and 1 partial ⚠️
tket2/src/circuit/command.rs 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   82.80%   82.81%           
=======================================
  Files          64       64           
  Lines        6561     6562    +1     
  Branches     6040     6041    +1     
=======================================
+ Hits         5433     5434    +1     
  Misses        851      851           
  Partials      277      277           
Flag Coverage Δ
python 96.73% <ø> (ø)
rust 81.60% <93.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I was not expecting it to be this easy.

let [TypeArg::Opaque { arg }] = arg_values else {
// This should have already been checked.
panic!("Wrong number of arguments");
};
let op: OpaqueTk1Op = serde_yaml::from_value(arg.value.clone()).unwrap(); // TODO Errors!
Ok(op.signature().into())
let poly_func: PolyFuncType = op.signature().into();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annoying, I see you have created an issue for this already

@doug-q doug-q added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 4bd81c3 Jul 19, 2024
16 checks passed
@doug-q doug-q deleted the ab/update-hugr-0.9 branch July 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants