feat!: get pauli propagation + examples working with new hugr builder #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
commented
Jul 9, 2024
pyproject.toml
Outdated
| @@ -36,7 +38,8 @@ mypy = "^1.10.1" | |||
| hypothesis = "^6.105.1" | |||
| graphviz = "^0.20" | |||
| pre-commit = "^3.7.1" | |||
| guppylang = "^0.6.0" | |||
| # guppylang = "^0.6.0" | |||
| guppylang = { git = "https://github.com/CQCL/guppylang", rev = "3da3936" } | |||
There was a problem hiding this comment.
needed for hugr-py compatibility
There was a problem hiding this comment.
This will prevent us from releasing new tket2-py versions. Can we do a guppy release soon?
ss2165
commented
Jul 9, 2024
| @@ -178,7 +178,7 @@ impl Tk2Circuit { | |||
| Ok(self.clone()) | |||
| } | |||
|
|
|||
| fn node_op(&self, node: PyNode) -> PyResult<PyCustomOp> { | |||
| fn node_op(&self, node: PyNode) -> PyResult<Cow<[u8]>> { | |||
Currently requires some horrible hacks like converting nodes via ints and loading operations from bytes. This will be cleared up by fully using the `hugr` package Node, Wire, ops, types in the `TK2Circuit` interface instead of ad-hoc bindings in a follow up PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 82.22% 82.19% -0.04%
==========================================
Files 60 60
Lines 5919 5920 +1
Branches 5410 5399 -11
==========================================
- Hits 4867 4866 -1
- Misses 793 798 +5
+ Partials 259 256 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
approved these changes
Jul 9, 2024
pyproject.toml
Outdated
| @@ -36,7 +38,8 @@ mypy = "^1.10.1" | |||
| hypothesis = "^6.105.1" | |||
| graphviz = "^0.20" | |||
| pre-commit = "^3.7.1" | |||
| guppylang = "^0.6.0" | |||
| # guppylang = "^0.6.0" | |||
| guppylang = { git = "https://github.com/CQCL/guppylang", rev = "3da3936" } | |||
There was a problem hiding this comment.
This will prevent us from releasing new tket2-py versions. Can we do a guppy release soon?
| @@ -178,7 +178,7 @@ impl Tk2Circuit { | |||
| Ok(self.clone()) | |||
| } | |||
|
|
|||
| fn node_op(&self, node: PyNode) -> PyResult<PyCustomOp> { | |||
| fn node_op(&self, node: PyNode) -> PyResult<Cow<[u8]>> { | |||
tket2-py/tket2/circuit/build.py
Outdated
Comment on lines
115
to
120
| FLOAT_T = tys.Opaque( | ||
| extension="arithmetic.float.types", | ||
| id="float64", | ||
| args=[], | ||
| bound=tys.TypeBound.Copyable, | ||
| ) |
There was a problem hiding this comment.
This should be defined in hugr-py. Open an issue there?
There was a problem hiding this comment.
will do a PR adding some standard extension types
|
Will wait for hugr-py 0.4 release before mergin |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0a2](tket2-py-v0.1.0...tket2-py-v0.1.0a2) (2024-07-10) ### ⚠ BREAKING CHANGES * `Dfg` binding removed, replaced with builder from `hugr` package. ### Features * Add `lhs` and `rhs` bindings to `Rule` ([#440](#440)) ([49b1c89](49b1c89)) * get pauli propagation + examples working with new hugr builder [#465](#465) ([cab0d87](cab0d87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustin Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: get pauli propagation + examples working with new hugr builder #465
Currently requires some horrible hacks like converting nodes via ints and loading operations from bytes. This will be cleared up by fully using the
hugrpackage Node, Wire, ops, types in theTK2Circuitinterface instead of ad-hoc bindings in a follow up PR.Release-As: 0.1.0a1
BREAKING CHANGE:
Dfgbinding removed, replaced with builder fromhugrpackage.END_COMMIT_OVERRIDE