Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: init tket2-hseries #368

Merged
merged 8 commits into from
Jun 14, 2024
Merged

feat!: init tket2-hseries #368

merged 8 commits into from
Jun 14, 2024

Conversation

doug-q
Copy link
Contributor

@doug-q doug-q commented May 29, 2024

BREAKING CHANGE: require hugr-0.5.0

@doug-q doug-q requested a review from aborgna-q May 29, 2024 07:46
@doug-q doug-q marked this pull request as draft May 29, 2024 07:47
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (b0b8aff) to head (77654df).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #368       +/-   ##
===========================================
+ Coverage   82.24%   96.00%   +13.76%     
===========================================
  Files          50       15       -35     
  Lines        5113      476     -4637     
  Branches     4637        0     -4637     
===========================================
- Hits         4205      457     -3748     
+ Misses        711       19      -692     
+ Partials      197        0      -197     
Flag Coverage Δ
python 96.00% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doug-q doug-q force-pushed the doug/init-tket2-ngrte branch 2 times, most recently from 8edcbe3 to 3b62d2f Compare May 30, 2024 07:47
@doug-q doug-q changed the title DRAFT: feat: init tket2-ngrte DRAFT: feat: init tket2-hseries May 30, 2024
@doug-q doug-q changed the title DRAFT: feat: init tket2-hseries feat!: init tket2-hseries May 30, 2024
@doug-q doug-q marked this pull request as ready for review May 30, 2024 07:48
@doug-q
Copy link
Contributor Author

doug-q commented May 30, 2024

Is this a breaking change?

I've added the new crate to default-members, lmk if you disagree with this.

Of course please lmk if you think any of the docs should be changed or improved.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Please add this to the end of release-plz.toml:

[[package]]
name = "tket2-hseries"
release = true

# Disabled until the first version is manually published
publish = false
git_tag_enable = false
git_release_enable = false

Copy link
Collaborator

@aborgna-q aborgna-q May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expand this a bit more.
See the hugr-cli's README for a template.

hugr.workspace = true
hugr-cli = { workspace = true, optional = true }
clap = { workspace = true, optional = true, features = ["derive"] }
tket2.workspace = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tket2 is currently a workspace dependency, but I think it works better with release-plz if you define explicitly here;

Suggested change
tket2.workspace = true
tket2 = { path = "../tket2", version = "0.1.0-alpha.1" }

That version will get bumped in the release PR.

Can you also update tket2-py, and remove it from the workspace?

@aborgna-q
Copy link
Collaborator

aborgna-q commented May 30, 2024

And yes. Normally bumping a dependency is not a breaking change, but here we re-export Hugr so a breaking change in hugr is also a breaking change here.

@doug-q doug-q force-pushed the doug/init-tket2-ngrte branch from 5d0ee52 to a9069ec Compare June 3, 2024 11:51
@doug-q doug-q force-pushed the doug/init-tket2-ngrte branch from a9069ec to 4dcb6ff Compare June 3, 2024 11:57
@doug-q doug-q requested a review from aborgna-q June 3, 2024 11:58
@doug-q
Copy link
Contributor Author

doug-q commented Jun 3, 2024

I have omitted building and coverage badges because they're not tket2-hseries specific. Do let me know if you disagree or need any other changes.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We should add the --help output to the README (or an example) once there's something there.

@doug-q doug-q force-pushed the doug/init-tket2-ngrte branch from 321288e to 21fd95d Compare June 6, 2024 08:16
@doug-q doug-q added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 61e7535 Jun 14, 2024
16 checks passed
@doug-q doug-q deleted the doug/init-tket2-ngrte branch June 14, 2024 06:30
@hugrbot hugrbot mentioned this pull request Jun 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
🤖 I have created a release *beep* *boop*
---


## 0.1.0 (2024-06-28)


### ⚠ BREAKING CHANGES

* require `hugr-0.5.0`
* Replaced `tket2.circuit.OpConvertError` with
`tket2.circuit.TK1ConvertError` in the python lib.
* Moved `tket2::json` to `tket2::serialize::pytket`
* Replaced the `Circuit` trait with a wrapper struct.
* This is a breaking change to the compiled rewriter serialisation
format.

### Features

* Add a "progress timeout" to badger
([#259](#259))
([556cf64](556cf64))
* Add missing typing hints
([#352](#352))
([4990613](4990613))
* bindings for circuit cost and hash
([#252](#252))
([85ce5f9](85ce5f9))
* drop pyo3 core dep ([#355](#355))
([9f7d415](9f7d415))
* EccRewriter bindings
([#251](#251))
([97e2e0a](97e2e0a))
* guppy → pytket conversion
([#407](#407))
([8c5a487](8c5a487))
* Implement `PyErr` conversion locally in `tket2-py`
([#258](#258))
([3e1a68d](3e1a68d))
* init tket2-hseries ([#368](#368))
([61e7535](61e7535))
* pauli propagation use case example
([#333](#333))
([f46973c](f46973c))
* **py:** Allow using `Tk2Op`s in the builder
([#436](#436))
([aed8651](aed8651))
* Support any ops in portmatching
([#293](#293))
([6b05a05](6b05a05))
* **tket2-py:** Bind the `lower_to_pytket` pass in python
([#439](#439))
([8208324](8208324))
* Use tket1 and tket2 circuits interchangeably everywhere
([#243](#243))
([eac7acf](eac7acf))
* Utilities for loading compiled guppy circuits
([#393](#393))
([028779a](028779a))


### Bug Fixes

* failed importlib import
([#254](#254))
([b077660](b077660))
* induced cycles in depth optimisation
([#264](#264))
([68c9ff2](68c9ff2)),
closes [#253](#253)
* Make native py modules behave like python's
([#212](#212))
([4220038](4220038)),
closes [#209](#209)
* pytest failing to find `tket2` in CI
([#367](#367))
([a9df8e6](a9df8e6))
* **tket2-py:** Replace `with_hugr` helpers with `with_circ`, keeping
the circuit parent. ([#438](#438))
([b77b3cb](b77b3cb))


### Documentation

* Add some example notebooks for the python package.
([#443](#443))
([4ed276c](4ed276c)),
closes [#434](#434)
* Update tket2-py readme
([6c8f18a](6c8f18a))


### Code Refactoring

* Rename `tket2::json` into `tket2::serialize::pytket`
([#392](#392))
([93e611c](93e611c))
* Replace Circuit trait with a struct
([#370](#370))
([ec5dd22](ec5dd22))
* Simplify tket1 conversion errors
([#408](#408))
([b0b8aff](b0b8aff))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustin Borgna <[email protected]>
@hugrbot hugrbot mentioned this pull request Aug 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2024
## 🤖 New release
* `tket2`: 0.1.0-alpha.2 -> 0.1.0
* `tket2-hseries`: 0.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.1.0](tket2-v0.1.0-alpha.2...tket2-v0.1.0)
- 2024-08-01

### Bug Fixes
- Single source of truth for circuit names, and better circuit errors
([#390](#390))
- Support non-DFG circuits
([#391](#391))
- Portmatching not matching const edges
([#444](#444))
- Pattern matcher discriminating on opaqueOp description
([#441](#441))
- `extract_dfg` inserting the output node with an invalid child order
([#442](#442))
- Recompile ecc sets after
[#441](#441)
([#484](#484))

### Documentation
- Update tket2-py readme
([#431](#431))
- Better error reporting in portmatching
([#437](#437))
- Improved multi-threading docs for Badger
([#495](#495))

### New Features
- `Circuit::operations` ([#395](#395))
- tuple unpack rewrite ([#406](#406))
- guppy → pytket conversion
([#407](#407))
- Drop linear bits, improve pytket encoding/decoding
([#420](#420))
- *(py)* Allow using `Tk2Op`s in the builder
([#436](#436))
- Initial support for `TailLoop` as circuit parent
([#417](#417))
- Support tuple unpacking with multiple unpacks
([#470](#470))
- Partial tuple unpack ([#475](#475))
- [**breaking**] Compress binary ECCs using zlib
([#498](#498))
- Add timeout options and stats to Badger
([#496](#496))
- Expose advanced Badger timeout options to tket2-py
([#506](#506))

### Refactor
- [**breaking**] Simplify tket1 conversion errors
([#408](#408))
- Cleanup tket1 serialized op structures
([#419](#419))

### Testing
- Add coverage for Badger split circuit multi-threading
([#505](#505))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.1.0](https://github.com/CQCL/tket2/releases/tag/tket2-hseries-v0.1.0)
- 2024-08-01

### New Features
- [**breaking**] init tket2-hseries
([#368](#368))
- *(tket2-hseries)* Add `tket2.futures` Hugr extension
([#471](#471))
- Add lazify-measure pass
([#482](#482))
- add results extensions
([#494](#494))
- *(tket2-hseries)* [**breaking**] Add `HSeriesPass`
([#487](#487))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Douglas Wilson <[email protected]>
@hugrbot hugrbot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants