chore: update deps #247
Merged
chore: update deps #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 82.57% 82.54% -0.04%
==========================================
Files 34 34
Lines 4242 4246 +4
Branches 4143 4147 +4
==========================================
+ Hits 3503 3505 +2
- Misses 553 554 +1
- Partials 186 187 +1 ☔ View full report in Codecov by Sentry. |
ss2165
approved these changes
Nov 20, 2023
| @@ -1,6 +1,4 @@ | |||
| //! Python bindings for TKET2. | |||
| #![warn(missing_docs)] | |||
There was a problem hiding this comment.
Yes, that's the
[lints]
workspace = truein Cargo.toml (since rust 1.74)
| num_bits += 1 | ||
| } else if ty == &FLOAT64_TYPE { | ||
| num_params += 1 | ||
| if let Some(sig) = op.dataflow_signature() { |
There was a problem hiding this comment.
not for this PR but we might be able to use op: & impl DataflowOpTrait in this function instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws warnings in older rust versions due to the unrecognised fields, but works alright.