Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Port text deleted in https://github.com/CQCL/hugr/pull/694 . #244

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

cqc-alec
Copy link
Collaborator

There was no obvious place to put this text so I created a docs directory.

@cqc-alec cqc-alec requested a review from ss2165 November 15, 2023 11:40
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2d4c7e) 82.89% compared to head (565fab0) 82.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   82.89%   82.52%   -0.38%     
==========================================
  Files          34       34              
  Lines        4228     4228              
  Branches     4143     4143              
==========================================
- Hits         3505     3489      -16     
- Misses        536      553      +17     
+ Partials      187      186       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a reference + link to the main hugr spec, doesn't make much sense without it.

@cqc-alec cqc-alec requested a review from ss2165 November 15, 2023 12:06
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@cqc-alec cqc-alec added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit feef643 Nov 15, 2023
11 checks passed
@cqc-alec cqc-alec deleted the quantumdocs branch November 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants