Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add small parallel badger test #237

Merged
merged 2 commits into from
Nov 10, 2023
Merged

test: Add small parallel badger test #237

merged 2 commits into from
Nov 10, 2023

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Nov 10, 2023

Timeout=0, so runtime impact is minimal, and it's kept deterministic; the loop quits immediately and no rewrites are applied.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #237 (4d62919) into main (581350e) will increase coverage by 3.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   79.05%   82.42%   +3.37%     
==========================================
  Files          34       30       -4     
  Lines        4235     4149      -86     
  Branches     4150     4149       -1     
==========================================
+ Hits         3348     3420      +72     
+ Misses        700      542     -158     
  Partials      187      187              
Files Coverage Δ
tket2/src/optimiser/badger.rs 60.60% <100.00%> (+5.60%) ⬆️

... and 11 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aborgna-q aborgna-q requested a review from ss2165 November 10, 2023 16:47
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test is a copy of the one above with a couple of parameters changed so could be better with either a loop or even better rstest parametrisation...

@aborgna-q aborgna-q force-pushed the test/badger-parallel branch from 0d3c0be to ef76c89 Compare November 10, 2023 17:08
@aborgna-q aborgna-q force-pushed the test/badger-parallel branch from ef76c89 to 4d62919 Compare November 10, 2023 17:10
@aborgna-q aborgna-q enabled auto-merge November 10, 2023 17:10
@aborgna-q aborgna-q added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit d8a7bd5 Nov 10, 2023
11 checks passed
@aborgna-q aborgna-q deleted the test/badger-parallel branch November 10, 2023 17:14
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
## 🤖 New release
* `tket2`: 0.1.0-alpha.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.0.0-alpha.1](https://github.com/CQCL/tket2/releases/tag/tket2-v0.0.0-alpha.1)
- 2024-05-24

### Bug Fixes
- Check for rewrite composition in badger
([#255](#255))
- induced cycles in depth optimisation
([#264](#264))
- Encode opaque symbolic constants
([#273](#273))
- Correctly detect custom ops by name
([#281](#281))
- Track input linear units in `Command`
([#310](#310))
- Don't convert tket2 measurements into tket1 ops
([#331](#331))

### Documentation
- Expand the main module and README docs
([#298](#298))

### New Features
- add angle type to tket2 extension
([#231](#231))
- bindings for circuit cost and hash
([#252](#252))
- Implement `PyErr` conversion locally in `tket2-py`
([#258](#258))
- Add a "progress timeout" to badger
([#259](#259))
- [**breaking**] Add lexicographic cost
([#270](#270))
- rewrite tracing ([#267](#267))
- Move pre/post rewrite cost to the RewriteStrategy API
([#276](#276))
- [**breaking**] Lexicographic cost fn
([#277](#277))
- Return rewrite strategies as a generator
([#275](#275))
- add qalloc, qfree, reset ops
([#284](#284))
- [**breaking**] Support any ops in portmatching
([#293](#293))
- Add `PatternMatch::nodes` and `subcircuit` + matching example
([#299](#299))
- Use `IncomingPort` and `OutgoingPort` instead of `Port` where
possible. ([#296](#296))
- expose Tk2Op name ([#307](#307))

### Refactor
- Move tket2 code to a workspace member
([#210](#210))
- Restructure the python code
([#211](#211))
- s/taso/badger/ ([#228](#228))
- Move python bindings from `tket2` to `tket2-py`
([#235](#235))
- rename t2op ([#256](#256))

### Testing
- Add small parallel badger test
([#237](#237))
- fix non-deterministic badger test
([#245](#245))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Agustin Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants