Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use jemallocator by default for taso #198

Merged
merged 3 commits into from
Oct 24, 2023
Merged

perf: Use jemallocator by default for taso #198

merged 3 commits into from
Oct 24, 2023

Conversation

aborgna-q
Copy link
Collaborator

Also enables thin LTO on release builds.

Tested on barenco_tof_10, 10s timeout, single threaded, on my laptop.

Before / after:

@aborgna-q aborgna-q requested a review from doug-q October 24, 2023 10:03
doug-q
doug-q approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Should we also offer a configuration which uses the default global allocator?

taso-optimiser/Cargo.toml Show resolved Hide resolved
@aborgna-q aborgna-q enabled auto-merge October 24, 2023 11:22
@aborgna-q
Copy link
Collaborator Author

aborgna-q commented Oct 24, 2023 •
edited
Loading

I think defaulting to jemalloc when possible (so, outside windows) is generally better.
Note that this is only used for the taso-optimiser binary target; crate users are free to choose their own allocator.

@aborgna-q aborgna-q added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 038bb70 Oct 24, 2023
7 checks passed
@aborgna-q aborgna-q deleted the perf/taso-jemalloc branch October 24, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-q doug-q doug-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aborgna-q @doug-q