chore: update hugr dependency #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
chore/update-hugr
branch
from
474f9fe to
e9de224
Compare
cqc-alec
approved these changes
Oct 20, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
Computes the cost of the circuit before its hash, so we can now drop it immediately if we know it won't fit into the priority queue. My test of barenco_tof_10 (10s timeout) went from 30ms average:  <details> <summary>Detailed timings</summary> | | # matches | matching | rewriting | hashing | costs | enqueing | --- | --- | --- | --- | --- | --- | --- | count | 60.000000 | 60.000000 | 60.000000 | 60.000000 | 60.0 | 60.000000 mean |116.916667| 124.800000 | 18.883333 |29.850000 | 0.0 | 4.050000 std | 44.293433 | 25.392378 | 11.225111 | 9.719498 | 0.0 | 1.254483 min | 85.000000 | 102.000000 |11.000000 | 21.000000 |0.0 | 2.000000 25% | 99.000000 |114.000000 |15.000000 | 25.000000 | 0.0 | 3.000000 50% | 109.500000 |118.000000 | 17.000000| 28.000000 | 0.0 | 4.000000 75% | 118.500000 |127.000000 | 19.000000 | 30.000000 | 0.0 | 4.000000 max | 389.000000 | 280.000000| 95.000000 | 88.000000 | 0.0 | 8.000000 All times in ms. </details> To 5ms average:  <details> <summary>Detailed timings</summary> | | # matches | matching | rewriting | hashing | costs | enqueing | --- | --- | --- | --- | --- | --- | --- | count | 70.000000 | 70.000000| 70.000000 |70.000000 | 70.0 | 70.000000 mean |112.342857 | 124.371429 | 18.642857 | 5.014286 | 0.0 | 0.685714 std | 42.014796 | 13.990858 | 11.317597| 11.005259 | 0.0 | 1.620009 min | 77.000000 | 108.000000 | 12.000000 | 0.000000 | 0.0 | 0.000000 25% | 93.250000| 116.250000 | 15.000000 |0.000000 | 0.0| 0.000000 50% | 109.000000 | 119.000000 | 16.000000 | 0.000000 | 0.0| 0.000000 75% | 116.000000| 126.750000 | 19.000000 | 2.000000 | 0.0| 0.000000 max | 389.000000 |180.000000 | 101.000000 |60.000000 | 0.0 | 8.000000 All times in ms. </details> It improved running times by 15% in this case. ~Blocked by #192. Ignore the first commit in the meantime.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.