feat: Add Python TASO pass #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyrs/src/optimiser.rs
aborgna-q
approved these changes
Oct 10, 2023
pyrs/src/pass.rs
Outdated
| /// This requires a `nam_6_3.rwr` file in the current directory. The location | ||
| /// can alternatively be specified using the `rewriter_dir` argument. | ||
| #[pyfunction] | ||
| fn nam_taso_optimise( |
There was a problem hiding this comment.
This has almost the same doc as taso_optimise. The fact that one rebases and the other doesn't should be clear there.
Perhaps just have a rebase optional parameter that defaults to true?
There was a problem hiding this comment.
Yes, I've removed the nam_ variant (I had originially thought I would write some of this in Python, but chose to have it all in Rust in the end).
| 1 => (vec![1], vec![timeout]), | ||
| _ => unreachable!(), | ||
| }; | ||
| let optimiser = PyDefaultTasoOptimiser::load_precompiled(rewrite_dir.join("nam_6_3.rwr")); |
There was a problem hiding this comment.
The hardcoded file is sketchy... add a TODO to remove it for now.
lmondada
force-pushed
the
feat/taso-pass-py
branch
from
34ee863 to
daafc2c
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
In hindsight this should have been part of #180. However, note that the Python tests currently fail: I get a segmentation fault, no idea why! drive by: renamed `PyDefaultTasoOptimiser` -> `PyTasoOptimiser`. --------- Co-authored-by: Agustin Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful Python binding to create the pytket-hyper extension on top of.