feat: high(-er) level rule, find, apply API #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only returns first found match for now
aborgna-q
approved these changes
Oct 9, 2023
pyrs/src/lib.rs
Outdated
| SerialCircuit::encode(&self.0)?.to_tket1() | ||
| } | ||
|
|
||
| fn apply_match(&mut self, rw: CircuitRewrite) { |
There was a problem hiding this comment.
Export CircuitRewrite from the patterns module.
| #[derive(Clone)] | ||
| #[pyclass] | ||
| /// A rewrite rule defined by a left hand side and right hand side of an equation. | ||
| pub struct Rule(pub [Hugr; 2]); |
There was a problem hiding this comment.
Move this to a submodule. (And T2Circuit to circuit.rs).
pyrs/src/lib.rs
Outdated
|
|
||
| #[pyclass] | ||
| /// A manager for tket 2 operations on a tket 1 Circuit. | ||
| pub struct T2Circuit(Hugr); |
There was a problem hiding this comment.
Having this is nice for avoiding unnecessary roundtrips, but it'd be nice to be able to use this interchangeably with TKET1 circs. Open an issue to investigate options?
There was a problem hiding this comment.
I.e by defining some trait? Possibly but I fear surprise errors when conversion fails. Will raise issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only returns first found match for now