feat: JSON support for AngleAdd and float inputs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Oct 4, 2023
| assert_eq!(ser.commands[0].op.params, Some(vec![param_str.into()])); | ||
|
|
||
| // Note: this is not a proper roundtrip as the symbols f0 and f1 are not | ||
| // converted back to circuit inputs. This would require parsing symbolic |
There was a problem hiding this comment.
What does the result of deserializing look like? Normally I'd expect serializing and then deserializing should produce at least an equivalent hugr.
There was a problem hiding this comment.
For the input
graph TD
IN --> Rz
IN --> AngleAdd
IN --> AngleAdd --> Rz --> OUT
you'd get after a serialisation roundtrip
graph TD
IN --> Rz
C(const f0 + f1) --> Rz
Rz --> OUT
I don't see how to avoid this, short of fully parsing symbolics in rust and resolving each symbol to an input. Do you have any ideas?
There was a problem hiding this comment.
No, seems unavoidable, but the solution is quite fragile. However let's go with it for now.
There was a problem hiding this comment.
I've added issue #168 to keep track of this.
cqc-alec
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
@ss2165 I won't ask for a review from you given that you are probably busy, but feel free to have a look if you are interested and have a moment.
This isn't proper constant folding but does sort-of constant folding on the fly when serialising to TK1 json. It seemed the fastest solution to get what I needed.