feat: Add CircuitMut trait #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm changing this to also handle copyable wires, one minute! EDIT: done! |
|
EDIT: I've added a work-around with a TODO to simplify once the issue is resolved. |
lmondada
force-pushed
the
feat/circuit-mut
branch
from
9c15b66 to
2abeaf7
Compare
ss2165
requested changes
Sep 28, 2023
src/circuit.rs
Outdated
| @@ -120,18 +128,164 @@ pub trait Circuit: HugrView { | |||
| } | |||
| } | |||
|
|
|||
| /// A circuit object that can be mutated. | |||
| pub trait CircuitMut: Circuit + HugrMut { | |||
There was a problem hiding this comment.
I'm pretty sure this can be defined without the :Circuit requirement (just replace calls to input() and output() with get_io).
Further i don't think it needs to be a trait, just a remove_empty_wire generic function
ss2165
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this to remove qubits in patterns when they are empty.
I struggled a bit to figure out how to update the types correctly. I hope this is correct, but please have a close look at it, I do not know what I am doing.