feat!: Use CX count as default cost function #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmondada
changed the title
lmondada
changed the title
|
I've implemented |
ss2165
approved these changes
Sep 26, 2023
src/rewrite/strategy.rs
Outdated
Comment on lines
126
to
133
| pub fn exhaustive_cx() -> ExhaustiveRewriteStrategy<fn(&OpType) -> bool> { | ||
| ExhaustiveRewriteStrategy::with_predicate(is_cx) | ||
| } | ||
|
|
||
| /// Exhaustive rewrite strategy with CX count cost function and provided gamma. | ||
| pub fn exhaustive_cx_with_gamma(gamma: f64) -> ExhaustiveRewriteStrategy<fn(&OpType) -> bool> { | ||
| ExhaustiveRewriteStrategy::new(gamma, is_cx) | ||
| } |
There was a problem hiding this comment.
these would be nicer as associated functions of ExhaustiveRewriteStrategy
impl ExhaustiveRewriteStrategy<fn(&OpType) -> bool> {
pub fn exhaustive_cx() -> Self {
Self::with_predicate(is_cx)
}
}There was a problem hiding this comment.
Yes you are right, I did the same with default_with_eccs_json_file in TasoOptimiser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised testing #133 that
ExhaustiveRewriteStrategyhad its cost function (total gate count) hard coded. I changed that and used the opportunity to use CX count as the default cost function in bothExhaustiveRewriteStrategyand TASO.