Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add just to devenv #132

Merged
merged 3 commits into from
Sep 25, 2023
Merged

chore: add just to devenv #132

merged 3 commits into from
Sep 25, 2023

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 25, 2023

No description provided.

@ss2165 ss2165 requested a review from aborgna-q September 25, 2023 10:24
.gitignore Outdated
.pre-commit-config.yaml

justfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of adding just to the default environment if there are no justfiles that it can be run on?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developer specific justfiles was the thinking but I'll add mine for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for individuals to define their own extensions to the tket2 devenv? (Except for just patching the file)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be possible to define your own shell nix that imports the devenv

.gitignore Outdated
.pre-commit-config.yaml

justfile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to add your justfile?

justfile Outdated
cargo test

fix:
cargo flippy --fix --allow-staged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean clippy?

@ss2165 ss2165 merged commit 33cbc71 into main Sep 25, 2023
7 checks passed
@ss2165 ss2165 deleted the chore/just branch September 25, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants