feat: Split & reassemble circuit chunks #130
Conversation
TODO: reassemble them
|
I'll add some python bindings before marking this as ready. |
|
I'm not convinced by the python interface (see |
| .ok() | ||
| .unwrap(); |
There was a problem hiding this comment.
Because the linked_ports iterator does not implement debug, and exactly_one's error uses it.
There was a problem hiding this comment.
ah yes I recall using the same trick, might be worth putting a utility for this somewhere so we have a comment about this in one place
src/passes/chunks.rs
Outdated
|
|
||
| /// Insert the chunk back into a circuit. | ||
| /// | ||
| /// Returns a map from the original input/output wires to the inserted [`IncomingPorts`]/[`OutgoingPorts`]. |
There was a problem hiding this comment.
might be useful to add a comment saying one "Wire" could actually be connected
to many inputs
There was a problem hiding this comment.
I added a ChunkInsertResult with better docs.
src/passes/chunks.rs
Outdated
| for commands in &circ.commands().chunks(max_size) { | ||
| chunks.push(Chunk::extract( | ||
| circ, | ||
| commands.map(|cmd| cmd.node()), |
There was a problem hiding this comment.
might be nicer to move this map to the loop definition
circ.commands().map(|cmd| ...)
|
|
||
| let builder = FunctionBuilder::new(name, signature).unwrap(); | ||
| let inputs = builder.input_wires(); | ||
| let mut reassembled = builder.finish_hugr_with_outputs(inputs, ®ISTRY).unwrap(); |
There was a problem hiding this comment.
leave a comment/TODO here about updating the registry correctly as well
src/passes/chunks.rs
Outdated
| .collect() | ||
| } | ||
|
|
||
| /// Returns clones of the split circuits. |
This is a pass utility to split circuits into chunks that can be independently optimized.
Closes #129