Modify and fix CliffordResynthesis pass
#1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeat substituting the best found subcircuit as long as the two-qubit gate count is decreasing. "Best" means the one that reduces the two- qubit gate count the most.
cqc-alec
force-pushed
the
ae/fix-cliffresynth
branch
from
687ab31 to
9547488
Compare
cqc-melf
reviewed
Jul 2, 2024
| static bool resynthesise_cliffords( | ||
| Circuit &circ, | ||
| std::optional<std::function<Circuit(const Circuit &)>> transform = nullptr, | ||
| bool allow_swaps = true) { | ||
| bool changed = false; | ||
| for (const VertexSet &verts : | ||
| circ.get_subcircuits([](Op_ptr op) { return op->is_clifford(); })) { | ||
| while (true) { |
There was a problem hiding this comment.
Should this maybe better contain the break condition in the while line?
There was a problem hiding this comment.
It's a matter of preference. That would mean introducing an extra boolean variable outside the loop to control it, and modifying the variable inside the loop, whereas this way we don't need to do that. On balance I think the function is sufficiently small that the logic is apparent.
cqc-melf
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the promise made by, and the logic used in, the
CliffordResynthesis()pass, to avoid the issue described in #1468 .Related issues
Fixes #1468 .
Checklist