Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect controlled ConjugationBox handling #1118

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

yao-cqc
Copy link
Contributor

@yao-cqc yao-cqc commented Nov 9, 2023

Fixes #1109

@yao-cqc yao-cqc requested a review from cqc-alec November 9, 2023 12:48
@yao-cqc yao-cqc marked this pull request as ready for review November 9, 2023 12:48
@@ -14,8 +14,8 @@

#include "PermutationTestUtils.hpp"

#include <catch2/catch_test_macros.hpp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably merge #1113 first (have added you as reviewer).

Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once rebased on develop. Thanks!

Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should bump tket library version in 2 conanfiles too (not detected in PR because of recency of last push)...

@yao-cqc yao-cqc merged commit e5e0c3b into develop Nov 9, 2023
30 checks passed
@yao-cqc yao-cqc deleted the bugfix/controlled-PauliExpBox-missing-UnitID branch November 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuit with Controlled-PauliExpBox fails to compile for AerBackend
2 participants